Skip to content

Add network spec#6889

Merged
coignetp merged 3 commits into
masterfrom
paul/network-spec
Jun 12, 2020
Merged

Add network spec#6889
coignetp merged 3 commits into
masterfrom
paul/network-spec

Conversation

@coignetp

@coignetp coignetp commented Jun 12, 2020

Copy link
Copy Markdown
Contributor

What does this PR do?

Add spec for the network integration

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp
coignetp requested review from a team as code owners June 12, 2020 11:14
@codecov

codecov Bot commented Jun 12, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6889 into master will decrease coverage by 10.81%.
The diff coverage is n/a.

Impacted Files Coverage Δ
nginx/tests/test_unit.py
datadog_checks_base/tests/test_metadata.py
dns_check/tests/test_integration.py
..._checks_base/datadog_checks/base/stubs/__init__.py
...tras/datadog_checks/linux_proc_extras/__about__.py
gearmand/datadog_checks/gearmand/__about__.py
powerdns_recursor/tests/test_powerdns.py
envoy/tests/test_utils.py
clickhouse/datadog_checks/clickhouse/queries.py
...ests/tooling/config_validator/test_config_block.py
... and 873 more

mgarabed
mgarabed requested changes Jun 12, 2020
View reviewed changes
Comment thread network/assets/configuration/spec.yaml
mgarabed
mgarabed approved these changes Jun 12, 2020
View reviewed changes

@mgarabed mgarabed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@coignetp
coignetp merged commit f3fc1b1 into master Jun 12, 2020
@coignetp
coignetp deleted the paul/network-spec branch June 12, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgarabed mgarabed mgarabed approved these changes

Assignees

No one assigned

Labels

documentation integration/network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coignetp @mgarabed @ChristineTChen