Skip to content

Allow optional dependency installation for all checks#6589

Merged
ofek merged 3 commits into
masterfrom
ofek/req
May 7, 2020
Merged

Allow optional dependency installation for all checks#6589
ofek merged 3 commits into
masterfrom
ofek/req

Conversation

@ofek

@ofek ofek commented May 7, 2020

Copy link
Copy Markdown
Contributor

Motivation

Ease management of community integrations

Additional Notes

I intentionally included the templates for new Logs & JMX integrations so if Python parts are added no one will have to touch setup.py

@ofek
ofek requested review from a team and anshumgargdd as code owners May 7, 2020 06:57
@codecov

codecov Bot commented May 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6589 into master will increase coverage by 2.10%.
The diff coverage is n/a.

Impacted Files Coverage Δ
disk/tests/common.py 61.53% <0.00%> (-38.47%) ⬇️
disk/tests/conftest.py 85.71% <0.00%> (-11.43%) ⬇️
disk/datadog_checks/disk/disk.py 82.80% <0.00%> (-3.61%) ⬇️
disk/tests/test_filter.py 96.45% <0.00%> (-3.55%) ⬇️
...cks/dev/tooling/configuration/consumers/example.py
...hecks_base/datadog_checks/base/utils/containers.py
marathon/tests/test_unit.py
linux_proc_extras/tests/test_linux_proc_extras.py
...g_checks/base/checks/prometheus/prometheus_base.py
...nmetrics/datadog_checks/openmetrics/openmetrics.py
... and 556 more

This was referenced May 7, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anshumgargdd anshumgargdd Awaiting requested review from anshumgargdd
1 more reviewer
@therve therve therve approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration/all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ofek @therve