Handle invalid type for excluded_interfaces#5986
Merged
Merged
Conversation
Let's raise a proper error when the configuration is incorrect.
4 tasks
florimondmanca
suggested changes
Mar 6, 2020
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Nice lil' improvement 👍
hithwen
reviewed
Mar 6, 2020
| instance = {} | ||
|
|
||
| self._excluded_ifaces = instance.get('excluded_interfaces', []) | ||
| if not isinstance(self._excluded_ifaces, list): |
Contributor
There was a problem hiding this comment.
Shouldn't this happen at init time?
Contributor
There was a problem hiding this comment.
Ideally… Looks like the Network check is pretty old school as it actually uses the instance passed to .check() instead of self.instance… Looks like a candidate for a refactor IMO, though this PR is consistent with the rest of the config handling done here so far.
Contributor
Author
There was a problem hiding this comment.
Yeah we can do that later.
Co-Authored-By: Florimond Manca <[email protected]>
Codecov Report
|
albertvaka
approved these changes
Mar 6, 2020
albertvaka
left a comment
albertvaka
left a comment
Contributor
There was a problem hiding this comment.
Since this needs agent-platform's approval...
mgarabed
approved these changes
Mar 6, 2020
florimondmanca
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's raise a proper error when the configuration is incorrect.