Codecov Report

Merging #5764 into master will decrease coverage by 26.29%.
The diff coverage is n/a.

Just to clarify: I was saying fnmatchcase is super slow, as is everything else in the fnmatch module

The performant way to do this is calling https://docs.python.org/3/library/fnmatch.html#fnmatch.translate on all patterns, then '|'.join(patterns), then compile that and cache it

In the end you just call .search once

@ofek yes I got you point and this is not related to fnmatch. Just to avoid two unnecessary lookups in case ignore_metrics wasn't configured in the first place.

Just to clarify: I was saying fnmatchcase is super slow, as is everything else in the fnmatch module

The performant way to do this is calling https://docs.python.org/3/library/fnmatch.html#fnmatch.translate on all patterns, then '|'.join(patterns), then compile that and cache it

In the end you just call .search once

Out of curiosity, I wanted to bench this good idea (on the Mac + Python 3.7) on a KSM output (320M), time for 10 runs.

./test_py.py
With 5 excludes
FNMatch: 41.420358180999756
RESearch: 16.89269208908081
With 10 excludes
FNMatch: 78.64589977264404
RESearch: 22.81194281578064

Worth changing to this suggestion!

pushed an attempt with translate, compile and search.

@ofek shouldn't we implement a similar logic to match whitelisted metrics? https://github.com/DataDog/integrations-core/blob/master/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py#L564
I'd be happy to implement it in this PR.

Sure!