Gracefully handle /proc errors in network check#5245
Merged
Conversation
Member
Author
|
Working on fixing tests .. |
ofek
requested changes
Dec 18, 2019
Codecov Report
|
ofek
approved these changes
Dec 18, 2019
ofek
left a comment
ofek
left a comment
Contributor
There was a problem hiding this comment.
I'd do info, but up to you 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid Errors on OpenShift and other environments where /proc is not accessible due to permissions.
Additional Notes
Considered using
log.warninginstead, but existing try/catch already useslog.debugso thought it would be more important to be consistent.Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached