Skip to content

Add use_sudo option for collecting conntrack metrics with containers#4920

Merged
ChristineTChen merged 3 commits into
masterfrom
cc/no_sudo_docker
Oct 30, 2019
Merged

Add use_sudo option for collecting conntrack metrics with containers#4920
ChristineTChen merged 3 commits into
masterfrom
cc/no_sudo_docker

Conversation

@ChristineTChen

@ChristineTChen ChristineTChen commented Oct 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds try_sudo_conntrack flag to configurations to collect conntrack metrics without sudo for containers.

Updated contributor PR with feedback, see #4746.

Thanks, @stonith!

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen
ChristineTChen requested review from a team as code owners October 29, 2019 18:56
@ChristineTChen ChristineTChen mentioned this pull request Oct 29, 2019
Closed
6 tasks
@ChristineTChen ChristineTChen changed the title Add try_sudo option for collecting conntrack metrics with containers Add use_sudo option for collecting conntrack metrics with containers Oct 29, 2019
@codecov

codecov Bot commented Oct 29, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@cae4e8a). Click here to learn what that means.
The diff coverage is 100%.

Impacted Files Coverage Δ
network/tests/test_network.py 97.03% <ø> (ø)
network/datadog_checks/network/network.py 63.34% <100%> (ø)

@ChristineTChen
ChristineTChen merged commit 6e1c437 into master Oct 30, 2019
@ChristineTChen
ChristineTChen deleted the cc/no_sudo_docker branch October 30, 2019 15:06
@ChristineTChen ChristineTChen mentioned this pull request Oct 30, 2019
Closed
@stonith

stonith commented Oct 30, 2019

Copy link
Copy Markdown

Thanks! Sorry about that, I didn't get a chance to circle back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@therve therve therve approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration/network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristineTChen @stonith @therve