Fix metric submission for combined connection state#4473
Merged
Conversation
In #4346 we aggregated the output to reduce parsing time, but a bug was introduced where only the latest state was used for states that are combined (like SYN and FIN states). This adds a test and fixes it.
Codecov Report
|
1 similar comment
Codecov Report
|
therve
changed the title
hithwen
approved these changes
Aug 30, 2019
ofek
pushed a commit
that referenced
this pull request
Aug 30, 2019
In #4346 we aggregated the output to reduce parsing time, but a bug was introduced where only the latest state was used for states that are combined (like SYN and FIN states). This adds a test and fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4346 we aggregated the output to reduce parsing time, but a bug was
introduced where only the latest state was used for states that are
combined (like SYN and FIN states). This adds a test and fixes it.