Strip white space when reading from proc_conntrack_max_path#3365
Merged
Conversation
Running the check manually on agent 5 includes trailing whitespaces for the value.
```
Metrics:
[('system.net.conntrack.max',
1553479163,
'16384\n',
{'hostname': 'ubuntu-a5-1', 'type': 'gauge'})]
Events:
[]
Service Checks:
[]
Service Metadata:
[{}]
network (5.32.1)
----------------
- instance #0 [OK]
- Collected 1 metric, 0 events & 0 service checks
```
Note: Actual value is actually successfully converted to float so there should be no impact to the values seen in UI.
ian28223
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3365 +/- ##
===========================================
- Coverage 85.81% 68.39% -17.43%
===========================================
Files 703 4 -699
Lines 36420 386 -36034
Branches 4313 72 -4241
===========================================
- Hits 31255 264 -30991
+ Misses 3951 100 -3851
+ Partials 1214 22 -1192 |
ofek
approved these changes
Mar 25, 2019
ofek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
strips potential whitespaces when reading from
proc_conntrack_max_pathMotivation
Running the check manually on agent 5 includes trailing whitespaces for the value.
Additional Notes
Note: Actual value is actually successfully converted to float so there should be no impact to the values seen in UI.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached