Conversation
Codecov Report
@@ Coverage Diff @@
## master #3060 +/- ##
==========================================
- Coverage 83.55% 77.08% -6.47%
==========================================
Files 560 97 -463
Lines 25987 5145 -20842
Branches 3383 576 -2807
==========================================
- Hits 21713 3966 -17747
+ Misses 3271 1014 -2257
+ Partials 1003 165 -838 |
mfpierre
approved these changes
Jan 31, 2019
zippolyte
commented
Jan 31, 2019
|
|
||
| # for reasons unknown, flake8 says that pdh_mocks_fixture is unused, even though | ||
| # it's used below. noqa to suppress that error. | ||
| from datadog_test_libs.win.pdh_mocks import pdh_mocks_fixture, initialize_pdh_tests # noqa: F401 |
Contributor
Author
There was a problem hiding this comment.
@ofek re this: should we just make datadog_checks_test_helpers a pytest plugin, similar to datadog_checks_dev, so that the fixtures are automatically discovered by pytest ? That would allow us to use them without having to import them.
Contributor
There was a problem hiding this comment.
Yes, I haven't had time though
nmuesch
approved these changes
Jan 31, 2019
ofek
approved these changes
Jan 31, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bunch of flake8 errors across our checks
Motivation
master is broken
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?