Support Python 3#3005
Merged
Merged
Conversation
nmuesch
reviewed
Jan 22, 2019
| """ | ||
| metrics = dict.fromkeys(self.cx_state_gauge.values(), 0) | ||
| metrics = {} | ||
| for _, val in iteritems(self.cx_state_gauge.values): |
Contributor
There was a problem hiding this comment.
I think we can remove the call to values here
nmuesch
previously approved these changes
Jan 22, 2019
nmuesch
left a comment
nmuesch
left a comment
Contributor
There was a problem hiding this comment.
LGTM once Travis is green 💯
Codecov Report
@@ Coverage Diff @@
## master #3005 +/- ##
==========================================
- Coverage 84.47% 69.2% -15.27%
==========================================
Files 660 4 -656
Lines 35602 367 -35235
Branches 4197 70 -4127
==========================================
- Hits 30075 254 -29821
+ Misses 4289 91 -4198
+ Partials 1238 22 -1216 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Support for Python 3 to the network check
Motivation
🐍 3️⃣ 🚂
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?