Skip to content

Use device tag instead of the deprecated device_name parameter#2945

Merged
zippolyte merged 1 commit into
DataDog:masterfrom
aerostitch:network_device_name
Jan 15, 2019
Merged

Use device tag instead of the deprecated device_name parameter#2945
zippolyte merged 1 commit into
DataDog:masterfrom
aerostitch:network_device_name

Conversation

@aerostitch

@aerostitch aerostitch commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR removes a deprecation warning in the network module:

[ AGENT ] 2019-01-15 02:45:49 UTC | INFO | (runner.go:258 in work) | Running check network
[ AGENT ] 2019-01-15 02:45:49 UTC | WARN | (datadog_agent.go:149 in LogMessage) | (base.py:228) | DEPRECATION NOTICE: `device_name` is deprecated, please use a `device:` tag in the `tags` list instead                                    
[ AGENT ] 2019-01-15 02:45:49 UTC | INFO | (runner.go:324 in work) | Done running check network

Motivation

It's been a while I haven't done anything here! :)
More seriously I am working on the migration from dd-agent 5 to 6 and saw those warnings in the logs. It's an easy enough fix so here it goes.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

@aerostitch
aerostitch requested a review from a team as a code owner January 15, 2019 03:14
@codecov-io

codecov-io commented Jan 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2945 into master will decrease coverage by 16.96%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #2945       +/-   ##
===========================================
- Coverage   84.95%   67.98%   -16.97%     
===========================================
  Files         662        4      -658     
  Lines       37170      353    -36817     
  Branches     4396       66     -4330     
===========================================
- Hits        31577      240    -31337     
+ Misses       4307       91     -4216     
+ Partials     1286       22     -1264

@aerostitch aerostitch mentioned this pull request Jan 15, 2019
Merged
5 tasks
@zippolyte zippolyte changed the title Adding the device to the tags as device_name is deprecated. Use device tag instead of the deprecated device_name parameter Jan 15, 2019
zippolyte
zippolyte approved these changes Jan 15, 2019
View reviewed changes

@zippolyte zippolyte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for this and welcome back 🙂

@zippolyte
zippolyte merged commit 8b85cd7 into DataDog:master Jan 15, 2019
@aerostitch
aerostitch deleted the network_device_name branch January 15, 2019 19:37
@aerostitch

aerostitch commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

Cool thx! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zippolyte zippolyte zippolyte approved these changes

Assignees

No one assigned

Labels

community integration/network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aerostitch @codecov-io @zippolyte