Add support for mlx5_core drivers in ethtool integration [CMPT-3460]#20481
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2c2e569 to
3474d19
Compare
There was a problem hiding this comment.
Hi @41ks, thanks for the PR!
Just one comment - we keep track of which metrics are emitted by an integration in metadata.csv. The file also includes other information about the metrics such as a description and the unit of measure. Could you update it with the new metrics? Let me know if you have any question!
temporal-github-worker-1
Bot
added
agent/requested-changes
and removed
agent/review-requested
labels
3474d19 to
6a33817
Compare
temporal-github-worker-1
Bot
added
agent/approved
and removed
agent/requested-changes
labels
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
[email protected] unqueued this merge request |
|
/remove |
|
View all feedbacks in Devflow UI.
|
dd-devflow
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
### What does this PR do? The mlx5_core NIC metrics were added to the [python network check](DataDog/integrations-core#20481) after we had ported the ethtool parsing over so these were not being sent in our Azure staging clusters. This PR adds support for parsing those stats and comprehensive unit tests for the ethtool metrics in general. ### Motivation ### Describe how you validated your changes (if not by through tests) * Thorough unit tests * Will deploy on staging to confirm ### Possible Drawbacks / Trade-offs
### What does this PR do? The mlx5_core NIC metrics were added to the [python network check](DataDog/integrations-core#20481) after we had ported the ethtool parsing over so these were not being sent in our Azure staging clusters. This PR adds support for parsing those stats and comprehensive unit tests for the ethtool metrics in general. ### Motivation ### Describe how you validated your changes (if not by through tests) * Thorough unit tests * Will deploy on staging to confirm ### Possible Drawbacks / Trade-offs (cherry picked from commit decde86)
…40349) Backport decde86 from #40326. ___ ### What does this PR do? The mlx5_core NIC metrics were added to the [python network check](DataDog/integrations-core#20481) after we had ported the ethtool parsing over so these were not being sent in our Azure staging clusters. This PR adds support for parsing those stats and comprehensive unit tests for the ethtool metrics in general. ### Motivation ### Describe how you validated your changes (if not by through tests) * Thorough unit tests * Will deploy on staging to confirm ### Possible Drawbacks / Trade-offs Co-authored-by: Jeremy Hanna <[email protected]>
3 participants
What does this PR do?
This PR adds support for mlx5_core drivers in the network integration.
It does so by adding the metrics of interest in the const.py file.
Some logic was also added to allow for parsing of queue numbers on this type of interface.
Motivation
This PR enhances monitoring for interfaces using mlx5 drivers, such as those found in Azure VMs.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged