Retrieve no_proxy directly from the Datadog Agent's configuration#2004
Merged
Conversation
gzussa
approved these changes
Aug 7, 2018
ofek
approved these changes
Aug 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the check for the
no_proxyenvironment variables inget_instance_proxy. The logic should be done by the Datadog Agent and the https, http, and no_proxy options should all be available in the agents config to retrieve by the time the integrations request it.Motivation
User had a
no_proxysetup in the datadog.yaml file, however this wasn't being propogated to the integrations that useget_instance_proxyand instead these checks were using the proxy directly.Review checklist
no-changeloglabel attachedAdditional Notes
Noticed some commented out pdbs in the network check, so removed those for cleanliness