[mongo] removes confusing tags#186
Conversation
|
There is at least a lint error, and broken mongo tests. |
|
@truthbk this needs some reworking anyway, I know what to do though I think |
yannmh
left a comment
yannmh
left a comment
There was a problem hiding this comment.
The replication set name and state are relevant to the MongoDB host, not necessarily all of its metrics.
Having those tags defined for all metrics is not ideal, but I believe it's not wrong either: the check is kind of artificially creating a host tag by appending those to all metric tags.
The changes remove the replication metadata tags from all metrics. It's not a great as:
- This information is valuable on some metrics
- This is a backward compatibility breaker
Ideally, we'd add some logic to only tag the relevant metrics instead of having all metrics sharing the same tag set.
I suggest to block those changes for now and wait for more interests.
|
It will break too many things without a clear benefit. Closing. |
* Extract datadog tags into a template var * Support strings and hashes * Update docs for tag attribute * Add test coverage for tags (string, hash, empty hash value) Closes #186
4 participants
No description provided.