Remove deprecated tomcat.cache metrics#16650
Merged
FlorentClarret merged 1 commit intomasterfrom Jan 18, 2024
Merged
Conversation
3 tasks
Member
Author
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
ghost
added
the
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Test Results12 files 12 suites 1m 3s ⏱️ Results for commit 5c2d759. ♻️ This comment has been updated with latest results. |
Base automatically changed from
florentclarret/tomcat/update_metrics
to
master
January 18, 2024 09:51
FlorentClarret
force-pushed
the
florentclarret/tomcat/remove_metrics
branch
from
080a8b9 to
5c2d759
Compare
vivek-datadog
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove deprecated
tomcat.cachemetricsMotivation
Tomcat 7 EOLed 3 years ago and we do not have these metrics anymore.
Additional Notes
They are not tested anymore
datadoghq.atlassian.net/browse/AI-3731
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.