Add monotonic counts for some metrics#1551
Merged
Merged
Conversation
Add monotonic counts for tcp segments and udp datagrams. This allows more precise counting of incoming and outgoing segments and datagrams for a given time period. Count and rate metrics are also configurable, allowing users to prefer one type over the other. Fixes DataDog/dd-agent#2630
jalaziz
force-pushed
the
network_monotonic_count
branch
from
May 15, 2018 07:19
ff550d7 to
4d263f5
Compare
masci
changed the title
ofek
requested changes
May 22, 2018
ofek
left a comment
ofek
left a comment
Contributor
There was a problem hiding this comment.
This is awesome @jalaziz!
The new metrics will indeed need to be added to metadata.csv. It's a relatively straightforward process though! Please see:
https://docs.datadoghq.com/developers/integrations/integration_sdk/#metadata-csv
https://docs.datadoghq.com/developers/metrics/#how-do-submission-types-relate-to-datadog-in-app-types
| # combine_connection_states: no | ||
|
|
||
| # By default, most metrics are submitted as rates. | ||
| # However, some metrics like tcp/dup retransmissions and errors are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add monotonic counts for tcp segments and udp datagrams. This allows more
precise counting of incoming and outgoing segments and datagrams for a given
time period.
The following metrics are affected:
For backwards compatibility, the new metrics are suffixed with
.count.I've also added the ability to enable/disable rate-based and count-based metrics per the discussion in DataDog/dd-agent#2630
Motivation
This fixes DataDog/dd-agent#2630. It allows graphing and alerting on the precise number of segments, datagrams, or errors in a set time period.
Review checklist
documentation/no-changeloglabel attachedbeen opened on the documentation repo
Additional Notes
It may be useful to warn if users accidentally disable both types of metrics, but I wasn't sure if that was necessary.
I also did not add counts for the
bytes_rcvd,bytes_sent,packets_in, andpackets_outmetric. Counts could be useful, but rates seem more appropriate. Also, the naming ofpackets_in.countdoesn't help.I've also been debating switching the suffix to
.countinstead of_count, as it seems more appropriate.Finally, I was not sure if I need to update
metadata.csv.