Factor BSD class out#13314
Merged
Merged
Conversation
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
hithwen
commented
Nov 15, 2022
| return 0 | ||
|
|
||
| def _submit_regexed_values(self, output, regex_list, tags): | ||
| def submit_regexed_values(self, output, regex_list, tags): |
Contributor
Author
There was a problem hiding this comment.
renamed since it is called from bsd (it's also used for solaris)
hithwen
commented
Nov 15, 2022
| check_instance = LinuxNetwork('network', {}, [instance]) | ||
| with mock.patch('datadog_checks.network.check_linux.get_subprocess_output') as out: | ||
| out.side_effect = ss_subprocess_mock | ||
| check_instance._get_linux_sys_net = lambda x: True |
Contributor
Author
There was a problem hiding this comment.
this method does not exist
hithwen
marked this pull request as ready for review
November 15, 2022 13:49
iliakur
approved these changes
Nov 15, 2022
iliakur
left a comment
iliakur
left a comment
Contributor
There was a problem hiding this comment.
Hurray for more test coverage 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue network check refactor:
Out of the scope of this PR: refactor the code itself, it has been copied verbatim
Split of #13102