[network] Refactor: split check x methods into different classes#13102
Closed
hithwen wants to merge 21 commits into
Closed
[network] Refactor: split check x methods into different classes#13102hithwen wants to merge 21 commits into
hithwen wants to merge 21 commits into
Conversation
ghost
added
the
hithwen
changed the title
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split different implementations into different classes.
The main class now just has the initialisation and some auxiliary methods that are shared between two or more subclasses
Do not review. This PR is being split into multiple: