Exclude loopback interface from ethtool#13042
Merged
Merged
Conversation
Loopback interfaces doesn't support this ioctl call and they are not gonna expose driver specific informations. Exclude them so that we don't generate error logs.
ghost
added
Contributor
|
Label |
KSerrania
added
changelog/Fixed
category/bugfix
bonnefoa
marked this pull request as ready for review
October 4, 2022 12:32
KSerrania
changed the title
KSerrania
approved these changes
Oct 4, 2022
yzhan289
approved these changes
Oct 4, 2022
yzhan289
pushed a commit
that referenced
this pull request
Oct 4, 2022
* Exclude loopback interfaces lo and lo0 from SIOCETHTOOL Loopback interfaces doesn't support this ioctl call and they are not gonna expose driver specific informations. Exclude them so that we don't generate error logs. * Update configuration example to mention lo exclusion for ethtool
4 tasks
steveny91
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Exclude loopback interfaces lo and lo0 from SIOCETHTOOL Loopback interfaces doesn't support this ioctl call and they are not gonna expose driver specific informations. Exclude them so that we don't generate error logs. * Update configuration example to mention lo exclusion for ethtool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Loopback interfaces don't support ethtool ioctl call and they are not gonna expose driver specific informations.
Exclude them so that we don't generate error logs.
Motivation
We want to avoid error logs. While they don't have an impact, they certainly are noisy.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached