Add collection of ethtool queue stats#12023
Merged
Merged
Conversation
truthbk
previously approved these changes
May 13, 2022
truthbk
left a comment
Member
There was a problem hiding this comment.
Fix looks good and should avoid the segfault, also, the fix is portable given that u32 is not ever going to have a greater width than 4.
bonnefoa
force-pushed
the
bonnefoa/queue_stats_2
branch
2 times, most recently
from
May 30, 2022 11:37
45a67fb to
e4eb726
Compare
hithwen
reviewed
May 30, 2022
hithwen
reviewed
May 30, 2022
bonnefoa
force-pushed
the
bonnefoa/queue_stats_2
branch
from
August 16, 2022 13:22
abf7170 to
0dfe667
Compare
Contributor
|
The |
bonnefoa
force-pushed
the
bonnefoa/queue_stats_2
branch
from
August 16, 2022 15:23
0dfe667 to
d494615
Compare
bonnefoa
force-pushed
the
bonnefoa/queue_stats_2
branch
from
August 18, 2022 08:36
d494615 to
5d478cd
Compare
bkabrda
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR was previously applied in #11056
However, this triggered segfault as the buffer's size was incorrect as
_u32element was only counted as one byte.While the correct size should have been
A sizeof confirms it
Motivation
This will provide per queue stats.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached