Skip to content

Revert "Add collection of ethtool queue stats (#11056)"#12017

Merged
sarah-witt merged 1 commit into
masterfrom
sarah/revert-network-change
May 12, 2022
Merged

Revert "Add collection of ethtool queue stats (#11056)"#12017
sarah-witt merged 1 commit into
masterfrom
sarah/revert-network-change

Conversation

@sarah-witt

@sarah-witt sarah-witt commented May 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts commit 030f5bf.

What does this PR do?

Reverts "Add collection of ethtool queue stats"

Motivation

We've determined in test builds it causes the agent to crash on startup

Additional Notes

I've confirmed this was not released yet

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@sarah-witt
sarah-witt marked this pull request as ready for review May 12, 2022 19:44
@sarah-witt
sarah-witt requested review from a team as code owners May 12, 2022 19:44
@codecov

codecov Bot commented May 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #12017 (e6ec700) into master (9d442ef) will decrease coverage by 0.01%.
The diff coverage is 69.23%.

Flag Coverage Δ
network 79.92% <69.23%> (-3.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt
sarah-witt merged commit ba25dd5 into master May 12, 2022
@sarah-witt
sarah-witt deleted the sarah/revert-network-change branch May 12, 2022 20:35
bonnefoa added a commit that referenced this pull request May 13, 2022
@bonnefoa
Revert "Revert "Add collection of ethtool queue stats (#11056)" (#12017…
f0cac78 
…)"

This reverts commit ba25dd5.
bonnefoa added a commit that referenced this pull request May 30, 2022
@bonnefoa
Revert "Revert "Add collection of ethtool queue stats (#11056)" (#12017…
a8c7b58 
…)"

This reverts commit ba25dd5.
bonnefoa added a commit that referenced this pull request May 30, 2022
@bonnefoa
Revert "Revert "Add collection of ethtool queue stats (#11056)" (#12017…
980fb89 
…)"

This reverts commit ba25dd5.
bkabrda pushed a commit that referenced this pull request Sep 12, 2022
@bonnefoa
Add collection of ethtool queue stats (#12023)
6efebab 
* Revert "Revert "Add collection of ethtool queue stats (#11056)" (#12017)"
steveny91 pushed a commit that referenced this pull request Oct 27, 2022
@bonnefoa @steveny91
Add collection of ethtool queue stats (#12023)
3068c05 
* Revert "Revert "Add collection of ethtool queue stats (#11056)" (#12017)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@yzhan289 yzhan289 yzhan289 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation integration/network

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarah-witt @yzhan289