Skip to content

Add metric_patterns to base template#11696

Merged
sarah-witt merged 1 commit into
masterfrom
sarah/ddev-add-metrics-pattern-template
Mar 18, 2022
Merged

Add metric_patterns to base template#11696
sarah-witt merged 1 commit into
masterfrom
sarah/ddev-add-metrics-pattern-template

Conversation

@sarah-witt

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds metric_patterns to the base template

Motivation

#11508

Additional Notes

Will fail validation until #11695 is merged

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions

Copy link
Copy Markdown
Contributor

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov

codecov Bot commented Mar 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #11696 (8a7a7e3) into master (1860e24) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.20% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt
sarah-witt marked this pull request as ready for review March 17, 2022 18:31
@sarah-witt
sarah-witt requested a review from a team as a code owner March 17, 2022 18:31
@sarah-witt
sarah-witt merged commit 1314a92 into master Mar 18, 2022
@sarah-witt
sarah-witt deleted the sarah/ddev-add-metrics-pattern-template branch March 18, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants