Support Python checks defined by a pyproject.toml file#11233
Merged
Conversation
ghost
added
ofek
force-pushed
the
ofek/build
branch
2 times, most recently
from
January 28, 2022 21:48
c62b78b to
01c78dc
Compare
ofek
commented
Jan 28, 2022
Comment on lines
94
to
+97
| 'toml>=0.9.4, <1.0.0', | ||
| 'tomli>=2.0.0', | ||
| 'tomli-w>=1.0.0', |
Contributor
Author
There was a problem hiding this comment.
In a future PR we'll remove toml, hukkin/tomli#141
ofek
commented
Jan 28, 2022
Comment on lines
+181
to
+182
| # sort, and prevent backslash escapes since strings are written using double quotes | ||
| dependencies[:] = sorted(str(dependency).replace('"', "'") for dependency in dependencies) |
Contributor
|
The |
sarah-witt
reviewed
Feb 2, 2022
sarah-witt
reviewed
Feb 2, 2022
sarah-witt
left a comment
sarah-witt
left a comment
Contributor
There was a problem hiding this comment.
Looks great and works well! I left a few nits
Co-authored-by: Sarah Witt <[email protected]>
sarah-witt
previously approved these changes
Feb 3, 2022
sarah-witt
left a comment
sarah-witt
left a comment
Contributor
There was a problem hiding this comment.
I did some more testing and it looks good! Maybe one more thing we can do before migrating is update the package validation to validate more fields such as [tool.hatch.version]
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
* Support Python checks defined by a `pyproject.toml` file * Apply suggestions from code review Co-authored-by: Sarah Witt <[email protected]> * address Co-authored-by: Sarah Witt <[email protected]> 0263d56
This was referenced Feb 5, 2022
This was referenced Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
First step toward removing
setup.pyAdditional Notes
Can be tested with
postgreson https://github.com/DataDog/integrations-core/tree/ofek/build-test