Collect additional iface metrics: mtu, num tx/rx queue and tx queue length#11156
Merged
Conversation
ghost
added
the
bonnefoa
force-pushed
the
bonnefoa/mtu-collect
branch
from
January 18, 2022 09:44
8a80821 to
afc95a4
Compare
sarah-witt
reviewed
Jan 31, 2022
sarah-witt
previously approved these changes
Jan 31, 2022
sarah-witt
left a comment
sarah-witt
left a comment
Contributor
There was a problem hiding this comment.
Looks good for agent integrations!
albertvaka
previously approved these changes
Feb 2, 2022
albertvaka
left a comment
albertvaka
left a comment
Contributor
There was a problem hiding this comment.
LGTM. For consistency the metric descriptions should mention these are (Linux only), though.
Collaborator
Author
|
Added |
albertvaka
previously approved these changes
Feb 3, 2022
Co-authored-by: Sarah Witt <[email protected]>
bonnefoa
force-pushed
the
bonnefoa/mtu-collect
branch
from
February 15, 2022 13:54
f6a53e1 to
fdf61d3
Compare
Member
|
👋 from our end we've updated the metrics metadata tables in all DCs so we're ready when you are 👍 |
sarah-witt
approved these changes
Feb 17, 2022
albertvaka
approved these changes
Feb 17, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Collect iface metrics exposed in
/sys/class/neton linux.Motivation
Having MTU available is useful to chase down possible misconfigured instances which could increase IP fragmentation and lower network performance.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached