Add collection of ethtool queue stats#11056
Merged
Merged
Conversation
ghost
added
Contributor
|
The |
bonnefoa
changed the title
Contributor
|
The |
bonnefoa
force-pushed
the
bonnefoa/queue_stats
branch
2 times, most recently
from
January 13, 2022 13:06
d417dd3 to
0f53555
Compare
bonnefoa
force-pushed
the
bonnefoa/queue_stats
branch
from
March 30, 2022 08:36
ecac314 to
b0a556f
Compare
bonnefoa
force-pushed
the
bonnefoa/queue_stats
branch
from
April 25, 2022 12:04
b0a556f to
003ee9a
Compare
fanny-jiang
reviewed
Apr 25, 2022
Contributor
|
The |
bonnefoa
force-pushed
the
bonnefoa/queue_stats
branch
from
April 26, 2022 07:43
3a97426 to
391939a
Compare
mx-psi
reviewed
Apr 28, 2022
bonnefoa
force-pushed
the
bonnefoa/queue_stats
branch
from
April 28, 2022 13:18
391939a to
0e40bb1
Compare
Contributor
|
The |
bonnefoa
force-pushed
the
bonnefoa/queue_stats
branch
from
April 28, 2022 13:24
0e40bb1 to
6d62c11
Compare
mx-psi
approved these changes
Apr 28, 2022
Member
|
Ping me on Slack once you merge this please, we need to sync the metadata |
Collaborator
Author
|
I don't have permission to merge. |
Member
|
@fanny-jiang is this good to merge? |
fanny-jiang
approved these changes
May 2, 2022
sarah-witt
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit 030f5bf.
sarah-witt
added a commit
that referenced
this pull request
May 12, 2022
bonnefoa
added a commit
that referenced
this pull request
May 13, 2022
4 tasks
bonnefoa
added a commit
that referenced
this pull request
May 30, 2022
bonnefoa
added a commit
that referenced
this pull request
May 30, 2022
bkabrda
pushed a commit
that referenced
this pull request
Sep 12, 2022
steveny91
pushed a commit
that referenced
this pull request
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add collection of rx/tx queue and cpu statistics from ethtool.
Motivation
We currently don't have visibility on queue balancing.
A kernel patch recently introduced imbalance in our setup without us being aware (see cilium/cilium#18311).
Having those metrics will allow to check for possible imbalance in the infrastructure and help when tuning NIC configuration.
Additional Notes
As ethtool statistics are drivers specific, I've separated metrics using the driver name
ena ->
system.net.ena.queue.rx_cntvirtio ->
system.net.virtio_net.queue.rx_packetshyperv ->
system.net.hv_netvsc.cpu.rx_packetsThe main reason is to avoid confusion on which metric to use (
system.net.queue.rx_cntorsystem.net.queue.rx_packets?) when creating dashboards.Plus, the metric may have a different meaning depending on the driver.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached