Add saturation metrics for network#10551
Merged
Merged
Conversation
5 tasks
We currently gather utilization and error metrics of network (bytes received and sent, number of packets) but not the saturation metrics (number of dropped packets). Having this additional data is needed to apply the USE Method [1] for system performance analysis. [1] https://www.brendangregg.com/usemethod.html
luhenry
force-pushed
the
saturation-metrics
branch
from
November 3, 2021 14:29
0aa06fe to
c349fcb
Compare
|
Hey @luhenry, thanks for the PR! I think overall this looks ok, but I think it'd be best to only send the metric on platforms where we can actually collect them. I think sending |
Contributor
Author
|
@bkabrda I've updated the PR to not send |
bkabrda
suggested changes
Nov 9, 2021
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
Hi 👋 the code mostly looks good now, but there are some fixes that need to be made in order to ensure we don't break support for BSD/Solaris.
luhenry
force-pushed
the
saturation-metrics
branch
from
November 9, 2021 09:32
3e139e1 to
55a985c
Compare
luhenry
force-pushed
the
saturation-metrics
branch
from
November 9, 2021 09:56
55a985c to
8fc0988
Compare
bkabrda
previously approved these changes
Nov 9, 2021
bkabrda
approved these changes
Dec 21, 2021
coignetp
approved these changes
Dec 21, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add saturation metrics for network.
Motivation
We currently gather utilization and error metrics of network (bytes received and sent, number of packets) but not the saturation metrics (number of dropped packets).
Having this additional data is needed to apply the USE Method [1] for system performance analysis.
[1] https://www.brendangregg.com/usemethod.html
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached