Disable generic tags#10027
Conversation
…uration/instances/default.yaml Co-authored-by: Paul <[email protected]>
ghost
added
integration/spark
integration/sqlserver
integration/squid
integration/ssh_check
integration/statsd
integration/supervisord
integration/system_core
integration/system_swap
integration/tcp_check
integration/teamcity
integration/tls
integration/tomcat
integration/twemproxy
integration/twistlock
integration/varnish
integration/vault
integration/vertica
integration/voltdb
integration/vsphere
labels
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
I prefer this option, because it needs only one config flag, and new customers get rid of generic tags faster.
However, if I understand correctly, there is one use case we won't cover anymore ; we won't be able to consider more tags as generic without affecting existing users. If 2 months after merging this, we want to consider url tag as generic, they won't have any option to have <integration_name>_cluster tag and url tag at the same time.
I don't think it's such a big issue, since we probably won't update the generic tag list, but it's something we should be aware of.
With the previous implementation there were these cases:
With the current implementation:
But then I'll edit affected integrations to always emit new tag so effectively In both implementations the only way to add more tags is to edit the list |
2 participants
Alternate to #9853.
Adds a hidden feature flag to replace generic tags like "cluster" with non generic tags like "snowflake_cluster". This tag will be shown (by specs override) on affected integrations only.
In this model we only add one flag for disabling generic tags and the functionality of check_generic_tags would be added only to the affected integrations.
When reviewing focus on:
The rest are updated config models
Notes: