Docs, Specify exact buildpack version in example #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Jcambass Thanks, this is a good update. If I can make one request, let's keep the language a bit more formal and change "wanna" to "want to". The README is automatically pulled into a few different locations (e.g. Heroku's buildpack directory and Datadog's docs) where automatic language translation is applied. Using more formal language helps with automated translation. |
Heroku recommends to always specify a specific release when [using a 3rd party Buildpack](https://devcenter.heroku.com/articles/buildpacks#using-a-third-party-buildpack). Many people don't look at the heroku docs but only follow the README instructions of the repo. This causes some (sometimes hard to debug) problems because a unchanged build can suddenly fail because of changes on the Buildpacks master branch. To prevent people from accidentally using the master branch on the Buildpack in production I've included instructions on how to specify a specific Buildpack release in the README. Related issue #115
Contributor
Author
|
@jyee Thanks for hitting me at this! I've adjusted the wording. |
Contributor
|
@Jcambass thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heroku recommends to always specify a specific release when using a 3rd party Buildpack.
Many people don't look at the heroku docs but only follow the README instructions of the repo. This causes some (sometimes hard to debug) problems because a unchanged build can suddenly fail because of changes on the Buildpacks master branch.
To prevent people from accidentally using the master branch on the Buildpack in production I've included instructions on how to specify a specific Buildpack release in the README.
Related issue #115