[autoscaling] add spot scheduling#2621
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 6, 2026
Merged
Conversation
AlexanderYastrebov
force-pushed
the
alexander.yastrebov/spot-scheduling
branch
from
April 29, 2026 11:26
91a4baf to
9d79d81
Compare
AlexanderYastrebov
changed the title
AlexanderYastrebov
force-pushed
the
alexander.yastrebov/spot-scheduling
branch
3 times, most recently
from
April 29, 2026 12:04
abf2c19 to
278c2de
Compare
triviajon
force-pushed
the
triviajon/ipvpa
branch
from
April 29, 2026 13:20
28fa72a to
abef1eb
Compare
AlexanderYastrebov
force-pushed
the
alexander.yastrebov/spot-scheduling
branch
2 times, most recently
from
April 29, 2026 13:42
1b2feaf to
f9b5f9a
Compare
clamoriniere
reviewed
May 4, 2026
| | datadog.asm.sca.enabled | bool | `false` | Enable Application Security Management Software Composition Analysis by injecting `DD_APPSEC_SCA_ENABLED=true` environment variable to all pods in the cluster | | ||
| | datadog.asm.threats.enabled | bool | `false` | Enable Application Security Management Threats App & API Protection by injecting `DD_APPSEC_ENABLED=true` environment variable to all pods in the cluster | | ||
| | datadog.autoscaling.workload.enabled | string | `nil` | Enable Workload Autoscaling. | | ||
| | datadog.autoscaling.workload.enabled | bool | `nil` | Enable Workload Autoscaling. | |
Collaborator
There was a problem hiding this comment.
if a new option (datadog.autoscaling.cluster.spot.enabled) is added it should be visible in this file
Contributor
Author
There was a problem hiding this comment.
The change is just a type hint for datadog.autoscaling.workload.enabled.
Its not GA so we do not show it here (similar to absent datadog.autoscaling.cluster.enabled).
clamoriniere
reviewed
May 4, 2026
AlexanderYastrebov
force-pushed
the
alexander.yastrebov/spot-scheduling
branch
from
May 5, 2026 10:34
f9b5f9a to
5ebe742
Compare
github-actions
Bot
added
the
chart/datadog
AlexanderYastrebov
force-pushed
the
alexander.yastrebov/spot-scheduling
branch
2 times, most recently
from
May 5, 2026 14:58
9ab4b10 to
5d72a30
Compare
AlexanderYastrebov
added
the
datadog/minor-version
AlexanderYastrebov
marked this pull request as ready for review
May 5, 2026 15:04
AlexanderYastrebov
requested review from
tedkahwaji
and removed request for
a team
May 5, 2026 15:04
clamoriniere
reviewed
May 6, 2026
| - watch | ||
| - patch | ||
| {{- end}} | ||
| {{- if or (((.Values.datadog.autoscaling).workload).enabled) ((((.Values.datadog.autoscaling).cluster).spot).enabled) }} |
Collaborator
There was a problem hiding this comment.
looks good but the re-ordering make the review difficult 😅
Contributor
Author
There was a problem hiding this comment.
Yes, but I actually made it to match datadog-operator configuration almost exactly so maybe in the future we can unify/reuse RBAC definition between operator and Helm.
clamoriniere
approved these changes
May 6, 2026
swang392
approved these changes
May 6, 2026
What does this PR do? --------------------- Adds `datadog.autoscaling.cluster.spot.enabled` to enable RBAC permissions for the spot instance scheduler in the Cluster Agent: - Deployments and StatefulSets (get, list, watch, patch) — to write the spot-disabled-until annotation during on-demand fallback. - pods/eviction (create) — to evict pending spot pods and trigger on-demand fallback rescheduling. Motivation ---------- The spot scheduler MVP was added in DataDog/datadog-agent#47429 (7.79.0). The equivalent operator change is in DataDog/datadog-operator#2957. Minimum Agent Versions ---------------------- * Cluster Agent: v7.79.0 Updates https://datadoghq.atlassian.net/browse/CASCL-1315 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
AlexanderYastrebov
force-pushed
the
alexander.yastrebov/spot-scheduling
branch
from
May 6, 2026 15:49
5d72a30 to
97ecbfc
Compare
gh-worker-dd-mergequeue-cf854d
Bot
merged commit May 6, 2026
07def5b
into
main
41 of 42 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
alexander.yastrebov/spot-scheduling
branch
May 6, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
datadog.autoscaling.cluster.spot.enabledto enable RBAC permissionsfor the spot instance scheduler in the Cluster Agent:
spot-disabled-until annotation during on-demand fallback.
on-demand fallback rescheduling.
Motivation
The spot scheduler MVP was added in DataDog/datadog-agent#47429
The equivalent operator change is DataDog/datadog-operator#2957
Minimum Agent Versions
Updates https://datadoghq.atlassian.net/browse/CASCL-1315
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)datadogchart changes, received ✅ from a member of your teamGitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md