Public API: Load()#17
Merged
Merged
Conversation
eliottness
approved these changes
Jul 4, 2023
eliottness
left a comment
Contributor
There was a problem hiding this comment.
LGTM (except maybe for the little comment i left)
Co-authored-by: Eliott Bouhana <[email protected]>
Co-authored-by: François Mazeau <[email protected]>
Hellzy
reviewed
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, this is a big-bang PR implementing:
func Load() (ok bool, err error)to ease the integration in dd-trace-go so that we can distinguish the different possible error cases:PanicErrorerror type.UnsupportedTargeterror type.okisfalse, so that the caller knows it cannot use the package.okbeingtrueso that the caller can log the error and continue its startup.Health()has been kept for the sake of simplicity health-checking cases such as in the tests, where it returns theLoad()error only ifokis false, meaning that go-libddwaf is not healthy.waf_dl_unsupported.gofile.