Centralize missing FFE fixture cases#9
Merged
leoromanovsky merged 2 commits intoMay 13, 2026
Conversation
This was referenced May 12, 2026
leoromanovsky
marked this pull request as ready for review
May 13, 2026 01:07
leoromanovsky
requested review from
greghuels and
sameerank
and removed request for
a team
May 13, 2026 01:07
sameerank
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FFE SDK consumers have fixture cases that are not present in the canonical
ffe-system-test-datarepo. Before migrating consumers to git submodules, the canonical source needs to include those shared cases with linked evidence showing where each migrated fixture came from.Changes
test-case-race-conditions.jsonfixture totest-case-numeric-one-of-default.jsonbecause the fixture validates default behavior, not concurrency.Decisions
targetingKey,attributes,result.value, andresult.reasonfields where older consumer fixtures omitted them.Evidence
test-case-null-targeting-key.jsoncomes fromdd-trace-go: https://github.com/DataDog/dd-trace-go/blob/5fd6d9c4d6f7c1718cbada1a91923fe1622e5f3f/openfeature/testdata/evaluation-cases/test-case-null-targeting-key.json#L1-L40libdatadog: https://github.com/DataDog/libdatadog/blob/866d7c8a1eed40ab5b9ee46e7de924cdf304ce91/datadog-ffe/tests/data/tests/test-case-null-targeting-key.json#L1-L40test-case-numeric-one-of-default.jsonis the canonical name for Java's originaltest-case-race-conditions.json: https://github.com/DataDog/dd-trace-java/blob/710ca8758317ee5c09c15bb2e0f5808b75fc1b5f/dd-smoke-tests/openfeature/src/test/resources/data/test-case-race-conditions.json#L1-L10dd-trace-dotnetastest-case-race-conditions.json: https://github.com/DataDog/dd-trace-dotnet/blob/42c4df9daa4d3583142d6c12d2292f90410df015/tracer/test/Datadog.Trace.Tests/FeatureFlags/resources/data/test-case-race-conditions.json#L1-L10Validation
ufc-config.jsonand everyevaluation-cases/*.jsonfile.ufc-config.json, except the intentional missing-flag fixture.targetingKey,attributes,result.value, andresult.reason.evaluation-cases/*.json.