delay_serialization: implement feature#277
Merged
Merged
Conversation
pudiva
force-pushed
the
delay_serialization
branch
4 times, most recently
from
June 7, 2023 18:42
2e51125 to
d457d9e
Compare
Contributor
Author
pudiva
force-pushed
the
delay_serialization
branch
from
June 7, 2023 18:45
d457d9e to
378d519
Compare
Contributor
|
Hey @pudiva, thanks a lot for the PR. I'll do my best to give it a look soon 🙇 |
remeh
approved these changes
Jun 27, 2023
remeh
left a comment
remeh
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for the quality PR. I don't have anything major to report, it's elegantly integrated to the current codebase. I just left a remark, let me know WDYT and then we'll merge this one!
pudiva
force-pushed
the
delay_serialization
branch
from
July 4, 2023 21:53
378d519 to
57f3b23
Compare
Add the `delay_serialization` option, allowing users to delay expensive serialization until a more convenient time, such as after an HTTP request has completed. In multi-threaded mode, it causes serialization to happen inside the sender thread. Also, support the `sender_queue_size` in `single_thread` mode, so that it can benefit from the new `delay_serialization` option. Messages are now queued (possibly unserialized) until `sender_queue_size` is reached or `#flush` is called. It may be set to `Float::INFINITY`, so that messages are indefinitely queued until an explicit `#flush`. Fix DataDog#271 Co-Authored-By: Blake Williams <[email protected]>
pudiva
force-pushed
the
delay_serialization
branch
from
July 5, 2023 10:16
57f3b23 to
2f65360
Compare
Contributor
|
This will be part of next release (which should happen before the end of next week). Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
delay_serializationoption, allowing users to delay expensive serialization until a more convenient time, such as after an HTTP request has completed. In multi-threaded mode, it causes serialization to happen inside the sender thread.Also, support the
sender_queue_sizeinsingle_threadmode, so that it can benefit from the newdelay_serializationoption. Messages are now queued (possibly unserialized) untilsender_queue_sizeis reached or#flushis called. It may be set toFloat::INFINITY, so that messages are indefinitely queued until an explicit#flush.Fix #271