Conversation
gh123man
reviewed
Oct 18, 2022
gh123man
reviewed
Oct 18, 2022
gh123man
reviewed
Oct 18, 2022
gh123man
approved these changes
Oct 18, 2022
Member
gh123man
left a comment
gh123man
left a comment
There was a problem hiding this comment.
Just some clarifying questions - not blocking.
Otherwise LGTM 👍
Co-authored-by: Brian Floersch <[email protected]>
Co-authored-by: Brian Floersch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DogStatsdService.Configurenow takes an optional exception handler which is called when an error occurs. Previously, exceptions were logged usingDebug.WriteLine. In addition,DogStatsdService.Configuredoesn't throw an exception when an error occurs but returns false and the error is reported to the error handler.Note: This an API breaking changes.