Conversation
| public void Flush() | ||
| { | ||
| _statsdData?.Flush(); | ||
| _statsdData = null; |
There was a problem hiding this comment.
you dont need to create a new _statsdData?
gh123man
reviewed
Nov 19, 2020
|
|
||
| public void Dispose() | ||
| { | ||
| if (!_terminate) |
Member
There was a problem hiding this comment.
NIT: could flip this to reduce nesting:
if (_terminate) { return }
Contributor
Author
There was a problem hiding this comment.
I tend to use this pattern where there are several return in the function.
truthbk
approved these changes
Nov 20, 2020
|
any idea when a new version of https://www.nuget.org/packages/DogStatsD-CSharp-Client will be released with this? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Flushmethod in order to flush without disposing.It should fix #141