Test MetricSerializer, EventSerializer and ServiceCheckSerializer#124
Merged
Test MetricSerializer, EventSerializer and ServiceCheckSerializer#124
Conversation
Remove Add_XXX unit tests as there is no AddXXX method in ServiceCheckSerializer
Some Send_XXX methods were removed as they test code already tested.
ogaca-dd
commented
May 29, 2020
| result += MetricSerializer.ConcatTags(constantTags, tags); | ||
| result += MetricSerializer.ConcatTags(_constantTags, tags); | ||
|
|
||
| if (result.Length > MaxSize) |
Contributor
Author
There was a problem hiding this comment.
88643cf#diff-2b2429c2b7220221984fa0ab16b8924eL66:
In the previous version, when truncating the metric, GetCommand overload was called without constantTags which was an issue. As _constantTags is a member of EventSerializer, constantTags is always used in the new version.
ogaca-dd
commented
May 29, 2020
| } | ||
|
|
||
| result += MetricSerializer.ConcatTags(constantTags, tags); | ||
| result += MetricSerializer.ConcatTags(_constantTags, tags); |
truthbk
reviewed
Jul 10, 2020
Member
truthbk
left a comment
truthbk
left a comment
There was a problem hiding this comment.
I have a question, but this looks super clean to me! 💯
| @@ -0,0 +1,158 @@ | |||
| using System; | |||
…nto olivierg/SplitStatsdUnitTest # Conflicts: # src/StatsdClient/MetricSerializer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits the class
StatsdUnitTeststo testMetricSerializer,EventSerializerandServiceCheckSerializer.For reviewers:
Reviewing commit by commit is recommended to be time efficient.
EventSerializer,ServiceCheckSerializerandMetricSerializerhave some old code fromStatsdbut they will be completely refactored in the next PR.Can be merged when #123 is merged.