Skip to content
This repository was archived by the owner on Mar 25, 2024. It is now read-only.

Dogshell| Enable the type and aggregation_key argument to post event#87

Merged
bunelr merged 2 commits into
masterfrom
dogshell-args
May 7, 2014
Merged

Dogshell| Enable the type and aggregation_key argument to post event#87
bunelr merged 2 commits into
masterfrom
dogshell-args

Conversation

@bunelr

@bunelr bunelr commented May 6, 2014

Copy link
Copy Markdown
Contributor

Fixes #86
Also add the possibility to specify the aggregation_key from the dogshell command line

Comment thread src/dogapi/http/events.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source_type_name and event_type are two different fields, why not just name the parameter source_type_name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks

bunelr added a commit that referenced this pull request May 7, 2014
Dogshell| Enable the type and aggregation_key argument to post event
@bunelr
bunelr merged commit 52e1fdb into master May 7, 2014
@wang-arthur
wang-arthur deleted the dogshell-args branch December 10, 2014 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants