[PROF-9147] Document workaround for Ruby gc_finalize_deferred#22019
Merged
brett0000FF merged 2 commits intomasterfrom Mar 19, 2024
Merged
[PROF-9147] Document workaround for Ruby gc_finalize_deferred#22019brett0000FF merged 2 commits intomasterfrom
brett0000FF merged 2 commits intomasterfrom
Conversation
**What does this PR do?** This PR updates the Ruby troubleshooting documentation, now that a a new workaround exists and is auto-applied (<DataDog/dd-trace-rb#3473>). **Motivation:** Clarify that using the "no signals" workaround is no longer the recommended way to solve this issue.
ivoanjo
commented
Mar 1, 2024
Comment on lines
-97
to
+99
| [3]: https://github.com/DataDog/dd-trace-rb/releases/tag/v0.54.0 | ||
| [3]: https://github.com/datadog/dd-trace-rb/releases/tag/v1.21.0 |
Member
Author
There was a problem hiding this comment.
[3] was no longer being used so I ended up reusing it for this entry. (Its last usage was removed in #20779)
Contributor
Preview links (active after the
|
Member
Author
|
Version https://rubygems.org/gems/ddtrace/versions/1.21.0 is now out, this is ready for review/merging :) |
brett0000FF
approved these changes
Mar 19, 2024
brett0000FF
deleted the
ivoanjo/gc-finalize-deferred-document-workaround
branch
Member
Author
|
Thanks for getting this one merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This PR updates the Ruby troubleshooting documentation, now that a new workaround exists and is auto-applied (DataDog/dd-trace-rb#3473).
This clarifies that using the "no signals" workaround is no longer the recommended way to solve this issue.
Merge instructions
The dd-trace-rb release containing the fix (1.21.0) has not yet been released, so I'm queuing this documentation change but ask that we don't merge it yet, and I'll come back and leave a note once the release is out.
Additional notes
N/A