Fix DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED documentation#18812
Merged
Conversation
Contributor
rtrieu
requested changes
Jul 5, 2023
rtrieu
left a comment
rtrieu
left a comment
Contributor
There was a problem hiding this comment.
Super minor suggestion but otherwise looks good!
Co-authored-by: Rosa Trieu <[email protected]>
Contributor
Author
|
Thanks @rtrieu 🙏 I just applied it! In the meantime, I am reaching Go team. |
Go tracer team ensures the tracer behaves as expected here: DataDog/dd-trace-go#2101
Contributor
Author
|
I also update the Go tracer documentation. The Go tracer team ensures the tracer behaves as expected here. It should be ready for review / merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the documentation of
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLEDbehavior.Motivation
The description is not compliant with the RFC nor the documentation.
The issue was brought to eng from support.
Additional Notes
There is the same sentence for the Go Tracer. I don't know what the implementation status is or who to contact about it?
Reviewer checklist