Remove references to COR_PROFILER that are no longer needed with MSI#14980
Merged
Conversation
Contributor
Merged
51 tasks
cswatt
approved these changes
Aug 23, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies the .NET tracer/profiler install instructions
Motivation
After this PR, the MSI sets the
COR_PROFILERandCORECLR_PROFILERvariables globally, so there's no need to set them manually. Only applies to Windows MSI install optionPreview
https://docs-staging.datadoghq.com/andrew/update-env-vars/profiler/enabling/dotnet
https://docs-staging.datadoghq.com/andrew/update-env-vars/tracing/trace_collection/dd_libraries/dotnet-core.md
https://docs-staging.datadoghq.com/andrew/update-env-vars/tracing/trace_collection/dd_libraries/dotnet-framework.md
Additional Notes
N/A
Reviewer checklist