add support for max_traces_per_second option to datadog.conf#291
Merged
Conversation
Contributor
Author
|
Can someone please take a look at this? Anything that needs to be done before it's approved/merged? |
xvello
suggested changes
Mar 15, 2018
xvello
left a comment
xvello
left a comment
Contributor
There was a problem hiding this comment.
hi @joshuabaird ,
Sorry for the delay. The option name is indeed specific enough that prefixing it with trace_sampler is not necessary.
I just have one comment about how you handled the missing trace.sampler section, what do you think?
|
|
||
|
|
||
| ##### Core config ##### | ||
| sed -i '/^#.* \[trace.sampler\]/s/^# //' ${DD_ETC_ROOT}/datadog.conf |
Contributor
There was a problem hiding this comment.
Instead of adding the section here, what do you think about patching set_property in config_builder.py to do
if not self.config.has_section(section):
self.config.add_section(section)I do think failing in config_builder.py because the section does not exist is a bug.
Contributor
Author
There was a problem hiding this comment.
Good idea - much better than my original hack. Done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does two things:
[trace.sampler]section in the stockdatadog.confmax_traces_per_secondconfiguration option todatadog.confThis allows a user to configure this value by setting the
MAX_TRACES_PER_SECONDenvironment variable.Motivation
We are heavy users of APM. We require a higher
max_traces_per_secondthan what the default provides (10).What inspired you to submit this pull request?
The inability to configure
max_traces_per_secondvia an environment variable.