fix: out-of-bounds access in process_symbolization#533
Merged
Conversation
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
KowalskiThomas
force-pushed
the
dd/kowalski/fix/process-symbolization-oob
branch
2 times, most recently
from
April 1, 2026 11:39
9ab74a5 to
81467a8
Compare
KowalskiThomas
marked this pull request as ready for review
April 1, 2026 11:39
KowalskiThomas
force-pushed
the
dd/kowalski/fix/process-symbolization-oob
branch
from
April 1, 2026 11:56
81467a8 to
7abc1a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an out-of-bounds array access in the
process_symbolizationfunction insideddprof_pprof.cc.In the inner loop that collects consecutive locations for the same file,
indexis incremented via++indexbefore checkinglocs[index].symbol_idx. When the last element oflocsis reached inside the loop,indexbecomes equal tolocs.size()and the subsequent access tolocs[index]is out of bounds, result in undefined behavior.