Use standard install destinations instead of ddprof/ prefix#518
Merged
Conversation
Install rules used a `ddprof/` prefix on all destinations (bin, lib, include), producing non-standard paths like `<prefix>/ddprof/bin/ddprof`. This forced every consumer (Conan, cmake --install) to relocate files manually. Remove the prefix and let `CMAKE_INSTALL_PREFIX` control the layout. Update `setup_env.sh` to set the prefix to `../deliverables/ddprof` so the release tarball structure stays the same. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Collaborator
Author
|
I am not sure why the build status is not taking into account the custom build pipeline 🤔 |
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Allow collatz to be installed to a separate prefix from CMAKE_INSTALL_PREFIX. When COLLATZ_INSTALL_PREFIX is unset, behavior is unchanged. When set, collatz installs under that path instead, keeping collatz/ and ddprof/ as siblings in the release layout regardless of CMAKE_INSTALL_PREFIX. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
r1viollet
marked this pull request as ready for review
March 20, 2026 10:03
r1viollet
commented
Mar 20, 2026
| install(TARGETS collatz-profiling-static DESTINATION collatz) | ||
| set(COLLATZ_INSTALL_PREFIX | ||
| "" | ||
| CACHE PATH "Override install prefix for collatz (defaults to CMAKE_INSTALL_PREFIX)") |
Collaborator
Author
There was a problem hiding this comment.
this adds some complexity (to avoid having collatz in the same folder...) but it should not bother us too often
nsavoire
previously approved these changes
Mar 20, 2026
- COLLATZ_INSTALL_PREFIX is now the install root (not its parent); callers set the full path including the collatz/ dir, consistent with how CMAKE_INSTALL_PREFIX works for ddprof - Add COLLATZ_INSTALL_PREFIX to setup_env.sh (../deliverables/collatz) - Fix version.txt DESTINATION from "." to "" to avoid the cosmetic ./ prefix in cmake install output Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
r1viollet
force-pushed
the
r1viollet/fix/standard-install-destinations
branch
from
March 20, 2026 13:08
dc8f258 to
b7afdce
Compare
nsavoire
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Install rules used a
ddprof/prefix on all destinations (bin, lib, include), producing non-standard paths like<prefix>/ddprof/bin/ddprof. This forced every consumer (Conan, cmake --install) to relocate files manually.Remove the prefix and let
CMAKE_INSTALL_PREFIXcontrol the layout. Updatesetup_env.shto set the prefix to../deliverables/ddprofso the release tarball structure stays the same.Motivation
See original PR here.
Additional Notes
NA
How to test the change?
Requires downstream PR in ddprof-build.
Custom pipeline is here