Replace non-standard ABS macro with constexpr function for C++23 compat#517
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMar 19, 2026
Merged
Conversation
…atibility
The ABS macro in logger.hpp used typeof (GNU extension) and a
statement-expression ({...}), both rejected by strict C++23 mode.
Replace with a constexpr function that works under any C++ standard.
This lets ddprof compile when a parent project or Conan toolchain
injects -std=c++23 without GNU extensions.
Co-Authored-By: Claude & @xroche
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
nsavoire
approved these changes
Mar 19, 2026
Collaborator
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
r1viollet/feat/cxx23-compat
branch
March 19, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The ABS macro in logger.hpp used typeof (GNU extension) and a statement-expression ({...}), both rejected by strict C++23 mode. Replace with a constexpr function that works under any C++ standard.
This lets ddprof compile when a parent project or Conan toolchain injects -std=c++23 without GNU extensions.
Co-Authored-By: Claude & @xroche
Motivation
C++ 23 compilation
Additional Notes
NA
How to test the change?
We will need to add a C++ 23 build in the CI.