Skip to content

Fix exporter write error check#507

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
r1viollet/fix/exporter-write-error-check
Mar 6, 2026
Merged

Fix exporter write error check#507
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
r1viollet/fix/exporter-write-error-check

Conversation

@r1viollet

@r1viollet r1viollet commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Replaces following PR
Refer to original PR

xroche and others added 2 commits March 6, 2026 13:44
@xroche @r1viollet
Fix inverted write() error check in profile exporter
cfec4a2 
write() returns -1 on error, not 0. The previous check:
- Missed all real errors (ENOSPC, EIO, EPIPE)
- False-alarmed on legitimate 0-byte writes

Also handle short writes with a loop, since write() may return
less than the requested length.

Fixes #498
@r1viollet
Fix clang-tidy: declare ptr as const auto *
1823a95
@r1viollet
r1viollet requested a review from nsavoire as a code owner March 6, 2026 12:49
@r1viollet r1viollet mentioned this pull request Mar 6, 2026
Closed
@pr-commenter

pr-commenter Bot commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.23.0+a05bed2b.100856017 ddprof 0.23.0+f65de18f.100927497

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.23.0+a05bed2b.100856017 ddprof 0.23.0+f65de18f.100927497

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

nsavoire
nsavoire reviewed Mar 6, 2026
View reviewed changes
Comment thread src/exporter/ddprof_exporter.cc
@r1viollet
r1viollet requested a review from nsavoire March 6, 2026 15:31
@r1viollet

r1viollet commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-06 15:38:33 UTC ℹ️ Start processing command /merge

2026-03-06 15:38:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-03-06 17:16:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 22m (p90).

2026-03-06 17:31:16 UTC ℹ️ MergeQueue: This merge request was merged

@r1viollet r1viollet mentioned this pull request Mar 6, 2026
Closed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 045baa0 into main Mar 6, 2026
4 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the r1viollet/fix/exporter-write-error-check branch March 6, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsavoire nsavoire nsavoire approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r1viollet @nsavoire @xroche