Skip to content

Add SA_RESETHAND to SIGSEGV handler to prevent infinite signal loop#488

Merged
r1viollet merged 1 commit into
mainfrom
fix/sigsegv-handler-safety
Feb 13, 2026
Merged

Add SA_RESETHAND to SIGSEGV handler to prevent infinite signal loop#488
r1viollet merged 1 commit into
mainfrom
fix/sigsegv-handler-safety

Conversation

@r1viollet

@r1viollet r1viollet commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

This change was proposed by @yoochangyeon
Thank you for the proposal in #487
I am reopening the branch just to ensure CI runs.

Motivation

Please refer to #487

Additional Notes

NA

How to test the change?

NA

@r1viollet
r1viollet marked this pull request as ready for review February 12, 2026 12:46
@r1viollet
r1viollet requested a review from nsavoire as a code owner February 12, 2026 12:46
@r1viollet r1viollet mentioned this pull request Feb 12, 2026
Closed
@pr-commenter

pr-commenter Bot commented Feb 12, 2026

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.23.0+dee61e6b.94317364 ddprof 0.23.0+eabeca26.96066426

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Feb 12, 2026

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.23.0+dee61e6b.94317364 ddprof 0.23.0+eabeca26.96066426

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet

r1viollet commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Feb 12, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-02-12 13:07:06 UTC ℹ️ Start processing command /merge

2026-02-12 13:07:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-12 17:11:09 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@r1viollet
r1viollet merged commit 820196b into main Feb 13, 2026
3 of 4 checks passed
@r1viollet
r1viollet deleted the fix/sigsegv-handler-safety branch February 13, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsavoire nsavoire nsavoire approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r1viollet @nsavoire @yoochangyeon