Skip to content

CLI emprovements : add missing env vars#480

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
r1viollet/improve_cli
Dec 17, 2025
Merged

CLI emprovements : add missing env vars#480
dd-mergequeue[bot] merged 2 commits into
mainfrom
r1viollet/improve_cli

Conversation

@r1viollet

@r1viollet r1viollet commented Dec 12, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add env vars for most settings.
I just left out global & pid mode, as these are settings you would only configure from CLI.

Motivation

In library mode it was not easy to debug ddprof's config.

Additional Notes

NA

How to test the change?

DD_PROFILING_NATIVE_LOG_LEVEL=notice DD_SERVICE=test-agent DD_PROFILING_REMOTE_SYMBOLIZATION=true DD_PROFILING_SHOW_CONFIG=true ./profiler_demo

@r1viollet
CLI emprovements : add missing env vars
f9b4be6 
In library mode it was not easy to debug ddprof's config.
@r1viollet
r1viollet requested a review from nsavoire as a code owner December 12, 2025 17:41
@pr-commenter

pr-commenter Bot commented Dec 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.1+cd20b335.85847414 ddprof 0.22.1+0d0c9292.87273493

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Dec 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.1+cd20b335.85847414 ddprof 0.22.1+0d0c9292.87273493

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet

r1viollet commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Dec 17, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-12-17 13:15:40 UTC ℹ️ Start processing command /merge

2025-12-17 13:15:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-17 13:27:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-12-17 13:44:06 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit ddd6141 into main Dec 17, 2025
4 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the r1viollet/improve_cli branch December 17, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsavoire nsavoire nsavoire approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r1viollet @nsavoire