Skip to content

Avoid matching symbols at address 0#479

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
r1viollet/avoid_matching_symbol_at_addr_0
Dec 10, 2025
Merged

Avoid matching symbols at address 0#479
dd-mergequeue[bot] merged 1 commit into
mainfrom
r1viollet/avoid_matching_symbol_at_addr_0

Conversation

@r1viollet

@r1viollet r1viollet commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

Avoid matching symbols at address 0.

Motivation

This will help our backend trigger remote symbolication calls
Ticket number: SMPTNG-723

Additional Notes

NA

How to test the change?

Before we would have a single DD_AGENT_1 symbol and we would not trigger remote symbolication

image

@r1viollet
Avoid matching symbols at address 0
0783f1a 
This will help our backend trigger remote symbolication calls
@r1viollet
r1viollet requested a review from nsavoire as a code owner December 9, 2025 15:33
@pr-commenter

pr-commenter Bot commented Dec 9, 2025

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.1+a47306a9.84911381 ddprof 0.22.1+0783f1a6.85627764

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Dec 9, 2025

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.1+a47306a9.84911381 ddprof 0.22.1+0783f1a6.85627764

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet

r1viollet commented Dec 10, 2025

Copy link
Copy Markdown
Collaborator Author

For reference, matching fix in the agent is here: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/commit/6975db2ae280023390c684f5e3fa2d4bebb92057

@r1viollet

r1viollet commented Dec 10, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-12-10 09:02:57 UTC ℹ️ Start processing command /merge

2025-12-10 09:03:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-12-10 09:17:48 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit cd20b33 into main Dec 10, 2025
4 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the r1viollet/avoid_matching_symbol_at_addr_0 branch December 10, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsavoire nsavoire nsavoire approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r1viollet @nsavoire