elutils 0.194#477
Conversation
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
| || ! process->callbacks->memory_read (process->dwfl, val1, &val1, | ||
| - process->callbacks_arg)) | ||
| + -1, process->callbacks_arg)) | ||
| + regno, process->callbacks_arg)) |
There was a problem hiding this comment.
Is it intended to pass regno instead of -1 ?
Was it a bug in the initial patch (I don't remember the context of the patch) ?
There was a problem hiding this comment.
This is in expr_eval, so I think that regno will have -1 if register not relevant or the correct register number.
This was for red zone optim and to have a heuristic to avoid failing when we read past the stack if I remember.
There was a problem hiding this comment.
I would be in favour of keeping it and if we see any issues with red zone optim, we can revert.
There was a problem hiding this comment.
I have no idea if this is correct or not...
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
2 participants
What does this PR do?
Upgrade elfutils to 0.194
Motivation
Ensure we are up to date with recent elfutils versions before we troubleshoot unwinding issues.
Additional Notes
Requires following PR
How to test the change?
NA