Skip to content

Reduce poll timeout to 10ms#471

Merged
nsavoire merged 2 commits into
mainfrom
nsavoire/reduce_poll_timeout
Nov 6, 2025
Merged

Reduce poll timeout to 10ms#471
nsavoire merged 2 commits into
mainfrom
nsavoire/reduce_poll_timeout

Conversation

@nsavoire

@nsavoire nsavoire commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Reduce poll timeout to 10ms: sometimes in alloc_live_heap mode, consumer worker times out on poll call whereas there are many events to process in ringbuffer. It seems that producer fails to notify profiler through eventfd. Not sure why, this is a workaround.
  • Eagerly advance ring buffer reader position as soon as an event is processed

@nsavoire
nsavoire requested a review from r1viollet as a code owner November 6, 2025 10:12
@pr-commenter

pr-commenter Bot commented Nov 6, 2025

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.1+03559679.81363822 ddprof 0.22.1+7ee60557.81430542

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Nov 6, 2025

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.1+03559679.81363822 ddprof 0.22.1+7ee60557.81430542

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet r1viollet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsavoire
nsavoire merged commit 52c3b33 into main Nov 6, 2025
2 checks passed
@nsavoire
nsavoire deleted the nsavoire/reduce_poll_timeout branch November 6, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants