Skip to content

Use elf addresses by default#467

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
r1viollet/use_elf_addresses
Nov 5, 2025
Merged

Use elf addresses by default#467
dd-mergequeue[bot] merged 1 commit into
mainfrom
r1viollet/use_elf_addresses

Conversation

@r1viollet

Copy link
Copy Markdown
Collaborator

What does this PR do?

Remove the use of process addresses.

Motivation

This makes it easier to debug locations without considering mappings.

Additional Notes

NA

How to test the change?

Describe here in detail how the change can be validated. This is a great section to call out specific tests you've added or improved, or to acknowledge code sections which are particularly difficult to test.

Remove the use of process addresses.
This makes it easier to debug locations without considering mappings.
@pr-commenter

pr-commenter Bot commented Nov 5, 2025

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.0+05220387.80865719 ddprof 0.22.0+7dbdc709.81299185

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Nov 5, 2025

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.22.0+05220387.80865719 ddprof 0.22.0+7dbdc709.81299185

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 5, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-05 16:27:21 UTC ℹ️ Start processing command /merge


2025-11-05 16:27:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2025-11-05 16:43:13 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit a06d758 into main Nov 5, 2025
3 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the r1viollet/use_elf_addresses branch November 5, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants